# HG changeset patch # User Dan Fuhry # Date 1320989449 18000 # Node ID 5e946a3f405b073a6206b9ad9a1f1160b7b81a4f # Parent f2aa4bc50d2f86ba6c0f83751f09cdb1a7686029 Converted to tabs diff -r f2aa4bc50d2f -r 5e946a3f405b plugins/Yubikey.php --- a/plugins/Yubikey.php Sat May 29 04:35:49 2010 -0400 +++ b/plugins/Yubikey.php Fri Nov 11 00:30:49 2011 -0500 @@ -1,13 +1,13 @@ language ID => categories array, ( strings object => category \ - objects => strings ) + root => language ID => categories array, ( strings object => category \ + objects => strings ) All text leading up to first curly brace is stripped by the parser; using a code tag makes jEdit and other editors do automatic indentation and @@ -80,107 +80,107 @@ { - // english - eng: { - categories: [ 'meta', 'yubiauth', 'yubiucp', 'yubiacp' ], - strings: { - meta: { - yubiauth: 'Yubikey authentication messages', - yubiucp: 'Yubikey user CP', - yubiacp: 'Yubikey admin CP', - }, - yubiauth: { - msg_please_touch_key: 'Please touch your Yubikey', - msg_close_instructions: 'or press Esc', - msg_invalid_chars: 'OTP contains invalid characters', - msg_too_long: 'OTP is too long', - msg_validating_otp: 'Validating OTP...', - msg_otp_valid: 'OTP validated', - btn_enter_otp: 'Log in with Yubikey', - lbl_otp_field: 'Yubikey OTP:', - - ctl_btn_change_key: 'Change key', - ctl_btn_clear: 'Clear', - ctl_btn_enroll: 'Enroll', - ctl_status_enrolled_pending: 'Enrolled (pending)', - ctl_status_empty: 'Not enrolled', - ctl_status_remove_pending: 'Removed (pending)', - ctl_status_enrolled: 'Enrolled', - - err_invalid_otp: 'Your login was rejected because the Yubikey OTP you entered contains invalid characters.', - err_invalid_auth_url: 'Login with Yubikey was rejected because the URL to the authentication server is not valid.', - err_nothing_provided: 'You did not provide a Yubikey OTP or a username. One of these is required for login to work.', - err_must_have_otp: 'Please provide a Yubikey OTP to log in to this account.', - err_must_have_username: 'Please provide your username.', - err_must_have_password: 'Please enter your password in addition to your username and Yubikey.', - err_key_not_authorized: 'This Yubikey is not authorized on this site.', - err_otp_invalid_chars: '%this.yubiauth_err_invalid_otp%', - err_http_failed: 'Your OTP could not be validated because the authentication server could not be contacted. Technical error message: %http_error%', - err_missing_api_key: 'Your OTP could not be validated because no Yubico API key is registered on this site.', - err_http_response_error: 'Your OTP could not be validated because the Yubico authentication server reported an error.', - err_malformed_response: 'Your OTP could not be validated because the Yubico authentication server returned an unexpected response.', - err_timestamp_check_failed: 'Your OTP could not be validated because the timestamp of the response from the Yubico authentication server was out of bounds.', - err_response_missing_sig: 'Your OTP could not be validated because the Yubico authentication server did not sign its response.', - err_response_invalid_sig: 'Your OTP could not be validated because the signature of the authentication response was invalid.', - err_response_missing_status: '%this.yubiauth_err_malformed_response%', - err_response_ok: 'OTP is OK', - err_response_bad_otp: 'Authentication failed because the Yubikey OTP is invalid.', - err_response_replayed_otp: 'Authentication failed because the Yubikey OTP you entered has been used before.', - err_response_bad_signature: 'Authentication failed because the Yubico authentication server reported an invalid signature.', - err_response_missing_parameter: 'Authentication failed because of a Dan Fuhry error.', - err_response_no_such_client: 'Authentication failed because the Yubikey you used is not registered with Yubico.', - err_response_operation_not_allowed: 'Authentication failed because the Enano server was denied the request to validate the OTP.', - err_response_backend_error: 'Authentication failed because an unexpected problem happened with the Yubico server.', - err_response_security_error: 'Authentication failed because the Yubico authentication server reported an unknown security error.', - - specialpage_yubikey: 'Yubikey API' - }, - yubiucp: { - panel_title: 'Yubikey settings', - - msg_save_title: 'Yubikey preferences saved', - msg_save_body: 'Your preferences have been saved. You will be transferred back to the User CP momentarily.', - - field_enable_title: 'Enable Yubikey support on my account:', - field_enable_hint: 'Disabling support will remove any keys that are enrolled for your account.', - field_enable: 'Enabled', - field_keys_title: 'Enrolled Yubikeys:', - field_keys_hint: 'Enroll a Yubikey to allow it to log into your account.', - field_keys_maximum: 'You can enroll up to %max% Yubikeys.', - field_normal_flags: 'When logging in, ask me for:', - field_elev_flags: 'When performing sensitive operations, require:', - field_flags_keyonly: 'Just my Yubikey', - field_flags_username: 'My Yubikey and username', - field_flags_userandpw: 'My Yubikey, username and password', - field_allow_plain_login: 'Allow me to log in without my Yubikey', - field_allow_plain_login_hint: 'If this option is turned off, you will be unable to access your account if all of your enrolled Yubikeys become lost or broken. However, turning this option off provides greater security.', - err_double_enrollment: 'One of the Yubikeys you tried to enroll is already enrolled on another account on this website. A single Yubikey can only be associated with one account at a time.', - err_double_enrollment_single: 'The Yubikey you tried to enroll is already enrolled on another account on this website. A single Yubikey can only be associated with one account at a time.', - - reg_field_otp: 'Enroll a Yubikey:', - reg_field_otp_hint_optional: 'If you have a Yubikey, you can authorize it for use in your new account here.', - reg_field_otp_hint_required: 'Please enroll a Yubikey here to create an account. This is a required step.', - reg_err_otp_required: 'Please enroll a Yubikey to register on this site.', - reg_err_otp_invalid: 'Your Yubikey OTP failed to validate.' - }, - yubiacp: { - th: 'Yubikey authentication', - field_enable_title: 'Yubikey support:', - field_enable: 'Enable Yubikey authentication', - field_api_key: 'Yubico API key:', - field_api_key_id: 'Yubico numeric ID:', - field_auth_server: 'Authentication server URL:', - field_enroll_limit: 'Number of enrolled keys permitted per account:', - field_reg_require_otp_title: 'Yubikey required for registration:', - field_reg_require_otp_hint: 'If this is enabled, users will be asked to enroll a Yubikey during registration. The enrolled Yubikey will be authorized for the new account.', - field_reg_require_otp: 'Require Yubikey during registration', - field_use_local_pre: 'Or:', - field_use_local: 'Use local YMS', - - err_invalid_auth_server: 'The URL to the Yubikey authentication server that you entered is invalid.' - } - } - } + // english + eng: { + categories: [ 'meta', 'yubiauth', 'yubiucp', 'yubiacp' ], + strings: { + meta: { + yubiauth: 'Yubikey authentication messages', + yubiucp: 'Yubikey user CP', + yubiacp: 'Yubikey admin CP', + }, + yubiauth: { + msg_please_touch_key: 'Please touch your Yubikey', + msg_close_instructions: 'or press Esc', + msg_invalid_chars: 'OTP contains invalid characters', + msg_too_long: 'OTP is too long', + msg_validating_otp: 'Validating OTP...', + msg_otp_valid: 'OTP validated', + btn_enter_otp: 'Log in with Yubikey', + lbl_otp_field: 'Yubikey OTP:', + + ctl_btn_change_key: 'Change key', + ctl_btn_clear: 'Clear', + ctl_btn_enroll: 'Enroll', + ctl_status_enrolled_pending: 'Enrolled (pending)', + ctl_status_empty: 'Not enrolled', + ctl_status_remove_pending: 'Removed (pending)', + ctl_status_enrolled: 'Enrolled', + + err_invalid_otp: 'Your login was rejected because the Yubikey OTP you entered contains invalid characters.', + err_invalid_auth_url: 'Login with Yubikey was rejected because the URL to the authentication server is not valid.', + err_nothing_provided: 'You did not provide a Yubikey OTP or a username. One of these is required for login to work.', + err_must_have_otp: 'Please provide a Yubikey OTP to log in to this account.', + err_must_have_username: 'Please provide your username.', + err_must_have_password: 'Please enter your password in addition to your username and Yubikey.', + err_key_not_authorized: 'This Yubikey is not authorized on this site.', + err_otp_invalid_chars: '%this.yubiauth_err_invalid_otp%', + err_http_failed: 'Your OTP could not be validated because the authentication server could not be contacted. Technical error message: %http_error%', + err_missing_api_key: 'Your OTP could not be validated because no Yubico API key is registered on this site.', + err_http_response_error: 'Your OTP could not be validated because the Yubico authentication server reported an error.', + err_malformed_response: 'Your OTP could not be validated because the Yubico authentication server returned an unexpected response.', + err_timestamp_check_failed: 'Your OTP could not be validated because the timestamp of the response from the Yubico authentication server was out of bounds.', + err_response_missing_sig: 'Your OTP could not be validated because the Yubico authentication server did not sign its response.', + err_response_invalid_sig: 'Your OTP could not be validated because the signature of the authentication response was invalid.', + err_response_missing_status: '%this.yubiauth_err_malformed_response%', + err_response_ok: 'OTP is OK', + err_response_bad_otp: 'Authentication failed because the Yubikey OTP is invalid.', + err_response_replayed_otp: 'Authentication failed because the Yubikey OTP you entered has been used before.', + err_response_bad_signature: 'Authentication failed because the Yubico authentication server reported an invalid signature.', + err_response_missing_parameter: 'Authentication failed because of a Dan Fuhry error.', + err_response_no_such_client: 'Authentication failed because the Yubikey you used is not registered with Yubico.', + err_response_operation_not_allowed: 'Authentication failed because the Enano server was denied the request to validate the OTP.', + err_response_backend_error: 'Authentication failed because an unexpected problem happened with the Yubico server.', + err_response_security_error: 'Authentication failed because the Yubico authentication server reported an unknown security error.', + + specialpage_yubikey: 'Yubikey API' + }, + yubiucp: { + panel_title: 'Yubikey settings', + + msg_save_title: 'Yubikey preferences saved', + msg_save_body: 'Your preferences have been saved. You will be transferred back to the User CP momentarily.', + + field_enable_title: 'Enable Yubikey support on my account:', + field_enable_hint: 'Disabling support will remove any keys that are enrolled for your account.', + field_enable: 'Enabled', + field_keys_title: 'Enrolled Yubikeys:', + field_keys_hint: 'Enroll a Yubikey to allow it to log into your account.', + field_keys_maximum: 'You can enroll up to %max% Yubikeys.', + field_normal_flags: 'When logging in, ask me for:', + field_elev_flags: 'When performing sensitive operations, require:', + field_flags_keyonly: 'Just my Yubikey', + field_flags_username: 'My Yubikey and username', + field_flags_userandpw: 'My Yubikey, username and password', + field_allow_plain_login: 'Allow me to log in without my Yubikey', + field_allow_plain_login_hint: 'If this option is turned off, you will be unable to access your account if all of your enrolled Yubikeys become lost or broken. However, turning this option off provides greater security.', + err_double_enrollment: 'One of the Yubikeys you tried to enroll is already enrolled on another account on this website. A single Yubikey can only be associated with one account at a time.', + err_double_enrollment_single: 'The Yubikey you tried to enroll is already enrolled on another account on this website. A single Yubikey can only be associated with one account at a time.', + + reg_field_otp: 'Enroll a Yubikey:', + reg_field_otp_hint_optional: 'If you have a Yubikey, you can authorize it for use in your new account here.', + reg_field_otp_hint_required: 'Please enroll a Yubikey here to create an account. This is a required step.', + reg_err_otp_required: 'Please enroll a Yubikey to register on this site.', + reg_err_otp_invalid: 'Your Yubikey OTP failed to validate.' + }, + yubiacp: { + th: 'Yubikey authentication', + field_enable_title: 'Yubikey support:', + field_enable: 'Enable Yubikey authentication', + field_api_key: 'Yubico API key:', + field_api_key_id: 'Yubico numeric ID:', + field_auth_server: 'Authentication server URL:', + field_enroll_limit: 'Number of enrolled keys permitted per account:', + field_reg_require_otp_title: 'Yubikey required for registration:', + field_reg_require_otp_hint: 'If this is enabled, users will be asked to enroll a Yubikey during registration. The enrolled Yubikey will be authorized for the new account.', + field_reg_require_otp: 'Require Yubikey during registration', + field_use_local_pre: 'Or:', + field_use_local: 'Use local YMS', + + err_invalid_auth_server: 'The URL to the Yubikey authentication server that you entered is invalid.' + } + } + } } **!*/ diff -r f2aa4bc50d2f -r 5e946a3f405b plugins/yubikey/admincp.php --- a/plugins/yubikey/admincp.php Sat May 29 04:35:49 2010 -0400 +++ b/plugins/yubikey/admincp.php Fri Nov 11 00:30:49 2011 -0500 @@ -5,103 +5,103 @@ function yubikey_admin_cp_ui() { - global $lang; - ?> - - - get('yubiacp_th'); ?> - - - - - - get('yubiacp_field_enable_title'); ?> - - - - - - - - - get('yubiacp_field_api_key'); ?> - - - - - - - - - get('yubiacp_field_api_key_id'); ?> - - - - - - - - - get('yubiacp_field_auth_server'); ?> - - - - '; - echo $lang->get('yubiacp_field_use_local_pre'); - ?> '; - } - ?> - - - - - - get('yubiacp_field_enroll_limit'); ?> - - - - - - - - - get('yubiacp_field_reg_require_otp_title'); ?>
- get('yubiacp_field_reg_require_otp_hint'); ?> - - - - - - - + + + get('yubiacp_th'); ?> + + + + + + get('yubiacp_field_enable_title'); ?> + + + + + + + + + get('yubiacp_field_api_key'); ?> + + + + + + + + + get('yubiacp_field_api_key_id'); ?> + + + + + + + + + get('yubiacp_field_auth_server'); ?> + + + + '; + echo $lang->get('yubiacp_field_use_local_pre'); + ?> '; + } + ?> + + + + + + get('yubiacp_field_enroll_limit'); ?> + + + + + + + + + get('yubiacp_field_reg_require_otp_title'); ?>
+ get('yubiacp_field_reg_require_otp_hint'); ?> + + + + + + + ' . $lang->get('yubiacp_err_invalid_auth_server') . ''; + global $lang; + + // yubikey_enable, yubikey_api_key, yubikey_api_key_id, yubikey_auth_server, yubikey_enroll_limit + setConfig('yubikey_enable', isset($_POST['yubikey_enable']) ? '1' : '0'); + setConfig('yubikey_api_key', $_POST['yubikey_api_key']); + setConfig('yubikey_api_key_id', intval($_POST['yubikey_api_key_id'])); + setConfig('yubikey_enroll_limit', intval($_POST['yubikey_enroll_limit'])); + setConfig('yubikey_reg_require_otp', isset($_POST['yubikey_reg_require_otp']) ? '1' : '0'); + setConfig('yubikey_use_local_yms', isset($_POST['yubikey_use_local_yms']) && defined('YMS_INSTALLED') ? '1' : '0'); + + if ( preg_match('#^(?:https?://)?(\[?[a-z0-9-:]+(?:\.[a-z0-9-:]+\]?)*)(/.*)$#', $_POST['yubikey_auth_server']) ) + setConfig('yubikey_auth_server', $_POST['yubikey_auth_server']); + else + echo '
' . $lang->get('yubiacp_err_invalid_auth_server') . '
'; } diff -r f2aa4bc50d2f -r 5e946a3f405b plugins/yubikey/auth.php --- a/plugins/yubikey/auth.php Sat May 29 04:35:49 2010 -0400 +++ b/plugins/yubikey/auth.php Fri Nov 11 00:30:49 2011 -0500 @@ -1,7 +1,7 @@ attachHook('login_process_userdata_json', 'return yubikey_auth_hook_json($userinfo, $req["level"], @$req["remember"]);'); @@ -12,292 +12,292 @@ function yubikey_auth_hook_json(&$userdata, $level, $remember) { - global $db, $session, $paths, $template, $plugins; // Common objects - global $lang; - - $do_validate_otp = false; - $do_validate_user = false; - $do_validate_pass = false; - - $user_flag = ( $level >= USER_LEVEL_CHPREF ) ? YK_SEC_ELEV_USERNAME : YK_SEC_NORMAL_USERNAME; - $pass_flag = ( $level >= USER_LEVEL_CHPREF ) ? YK_SEC_ELEV_PASSWORD : YK_SEC_NORMAL_PASSWORD; - - $auth_log_prefix = ( $level >= USER_LEVEL_CHPREF ) ? 'admin_' : ''; - - // Sort of a hack: if the password looks like an OTP and the OTP field is empty, use the password as the OTP - if ( empty($userdata['yubikey_otp']) && preg_match('/^[cbdefghijklnrtuv]{44}$/', $userdata['password'] ) ) - { - $userdata['yubikey_otp'] = $userdata['password']; - } - - // Lockouts removed from here - they're done during preprocessing now. - - if ( !empty($userdata['username']) ) - { - // get flags - $q = $db->sql_query('SELECT user_id, user_yubikey_flags FROM ' . table_prefix . "users WHERE " . ENANO_SQLFUNC_LOWERCASE . "(username) = '" . $db->escape(strtolower($userdata['username'])) . "';"); - if ( !$q ) - $db->die_json(); - - if ( $db->numrows() < 1 ) - { - // Username not found - let the main login function handle it - $db->free_result(); - return null; - } - list($user_id, $flags) = $db->fetchrow_num(); - $flags = intval($flags); - // At the point the username is validated. - $do_validate_user = false; - $do_validate_pass = $flags & $pass_flag; - if ( empty($userdata['yubikey_otp']) ) - { - // no OTP was provided - // make sure the user has allowed logging in with no OTP - if ( !($flags & YK_SEC_ALLOW_NO_OTP) ) - { - // We also might have no Yubikeys enrolled. - $q = $db->sql_query('SELECT 1 FROM ' . table_prefix . "yubikey WHERE user_id = $user_id;"); - if ( !$q ) - $db->die_json(); - - if ( $db->numrows() > 0 ) - { - // Yep at least one key is enrolled. - // I don't think these should be logged because they'll usually just be innocent mistakes. - $db->free_result(); - return array( - 'mode' => 'error', - 'error' => 'yubiauth_err_must_have_otp' - ); - } - // Nope, no keys enrolled, user hasn't enabled Yubikey support - $db->free_result(); - } - // we're ok, use normal password auth - return null; - } - else - { - // user did enter an OTP; make sure it's associated with the username - $yubi_uid = $db->escape(substr($userdata['yubikey_otp'], 0, 12)); - $q = $db->sql_query('SELECT 1 FROM ' . table_prefix . 'yubikey WHERE yubi_uid = \'' . $yubi_uid . '\';'); - if ( !$q ) - $db->die_json(); - if ( $db->numrows() < 1 ) - { - $db->free_result(); - return array( - 'mode' => 'error', - 'error' => 'yubiauth_err_key_not_authorized' - ); - } - $db->free_result(); - $do_validate_otp = true; - } - } - else if ( !empty($userdata['yubikey_otp']) ) - { - // we have an OTP, but no username to work with - $yubi_uid = substr($userdata['yubikey_otp'], 0, 12); - if ( !preg_match('/^[cbdefghijklnrtuv]{12}$/', $yubi_uid ) ) - { - return array( - 'mode' => 'error', - 'error' => 'yubiauth_err_invalid_otp' - ); - } - $q = $db->sql_query('SELECT u.user_id, u.username, u.user_yubikey_flags FROM ' . table_prefix . "users AS u\n" - . " LEFT JOIN " . table_prefix . "yubikey AS y\n" - . " ON ( y.user_id = u.user_id )\n" - . " WHERE y.yubi_uid = '$yubi_uid'\n" - . " GROUP BY u.user_yubikey_flags;"); - if ( !$q ) - $db->_die(); - - if ( $db->numrows() < 1 ) - { - if ( !$do_validate_pass ) - $session->sql('INSERT INTO ' . table_prefix . "logs(log_type,action,time_id,date_string,author,edit_summary,page_text) VALUES\n" - . ' (\'security\', \'' . $auth_log_prefix . 'auth_bad\', '.time().', \'DEPRECATED\', \'(Yubikey)\', ' - . '\''.$db->escape($_SERVER['REMOTE_ADDR']).'\', ' . intval($level) . ')'); - - return array( - 'mode' => 'error', - 'error' => 'yubiauth_err_key_not_authorized' - ); - } - - list($user_id, $username, $flags) = $db->fetchrow_num(); - $do_validate_otp = true; - $do_validate_user = $flags & $user_flag; - $do_validate_pass = $flags & $pass_flag; - // to complete security logs later - $userdata['username'] = $username; - } - else - { - // Nothing - no username or OTP. This request can't be used; throw it out. - return array( - 'mode' => 'error', - 'error' => 'yubiauth_err_nothing_provided' - ); - } - if ( $do_validate_otp ) - { - // We need to validate the OTP. - $otp_check = yubikey_validate_otp($userdata['yubikey_otp']); - if ( !$otp_check['success'] ) - { - if ( !$do_validate_pass ) - $session->sql('INSERT INTO ' . table_prefix . "logs(log_type,action,time_id,date_string,author,edit_summary,page_text) VALUES\n" - . ' (\'security\', \'' . $auth_log_prefix . 'auth_bad\', '.time().', \'DEPRECATED\', \'(Yubikey)\', ' - . '\''.$db->escape($_SERVER['REMOTE_ADDR']).'\', ' . intval($level) . ')'); - - if ( $otp_check['error'] === 'http_failed' ) - { - return array( - 'mode' => 'error', - 'error' => 'yubiauth_err_' . $otp_check['error'], - 'http_error' => $otp_check['http_error'] - ); - } - return array( - 'mode' => 'error', - 'error' => 'yubiauth_err_' . $otp_check['error'] - ); - } - } - if ( $do_validate_user ) - { - if ( empty($username) ) - { - return array( - 'mode' => 'error', - 'error' => 'yubiauth_err_must_have_username' - ); - } - if ( strtolower($username) !== strtolower($userdata['username']) ) - { - // Username incorrect - if ( !$do_validate_pass ) - $session->sql('INSERT INTO ' . table_prefix . "logs(log_type,action,time_id,date_string,author,edit_summary,page_text) VALUES\n" - . ' (\'security\', \'' . $auth_log_prefix . 'auth_bad\', '.time().', \'DEPRECATED\', \'(Yubikey)\', ' - . '\''.$db->escape($_SERVER['REMOTE_ADDR']).'\', ' . intval($level) . ')'); - return array( - 'mode' => 'error', - 'error' => 'invalid_credentials' - ); - } - } - // Do we need to have the password validated? - if ( $do_validate_pass ) - { - if ( empty($userdata['password']) ) - { - return array( - 'mode' => 'error', - 'error' => 'yubiauth_err_must_have_password' - ); - } - // Yes; return and let the login API continue - return null; - } - else - { - // No password required; validated, issue session key - $session->sql('INSERT INTO ' . table_prefix . "logs(log_type,action,time_id,date_string,author,edit_summary,page_text) VALUES\n" - . ' (\'security\', \'' . $auth_log_prefix . 'auth_good\', '.time().', \'DEPRECATED\', \'' . $db->escape($userdata['username']) . '\', ' - . '\''.$db->escape($_SERVER['REMOTE_ADDR']).'\', ' . intval($level) . ')'); - - $q = $db->sql_query('SELECT password FROM ' . table_prefix . "users WHERE user_id = $user_id;"); - if ( !$q ) - $db->_die(); - - list($password) = $db->fetchrow_num(); - $db->free_result(); - - $session->register_session($user_id, $userdata['username'], $password, intval($level), $remember); - return true; - } + global $db, $session, $paths, $template, $plugins; // Common objects + global $lang; + + $do_validate_otp = false; + $do_validate_user = false; + $do_validate_pass = false; + + $user_flag = ( $level >= USER_LEVEL_CHPREF ) ? YK_SEC_ELEV_USERNAME : YK_SEC_NORMAL_USERNAME; + $pass_flag = ( $level >= USER_LEVEL_CHPREF ) ? YK_SEC_ELEV_PASSWORD : YK_SEC_NORMAL_PASSWORD; + + $auth_log_prefix = ( $level >= USER_LEVEL_CHPREF ) ? 'admin_' : ''; + + // Sort of a hack: if the password looks like an OTP and the OTP field is empty, use the password as the OTP + if ( empty($userdata['yubikey_otp']) && preg_match('/^[cbdefghijklnrtuv]{44}$/', $userdata['password'] ) ) + { + $userdata['yubikey_otp'] = $userdata['password']; + } + + // Lockouts removed from here - they're done during preprocessing now. + + if ( !empty($userdata['username']) ) + { + // get flags + $q = $db->sql_query('SELECT user_id, user_yubikey_flags FROM ' . table_prefix . "users WHERE " . ENANO_SQLFUNC_LOWERCASE . "(username) = '" . $db->escape(strtolower($userdata['username'])) . "';"); + if ( !$q ) + $db->die_json(); + + if ( $db->numrows() < 1 ) + { + // Username not found - let the main login function handle it + $db->free_result(); + return null; + } + list($user_id, $flags) = $db->fetchrow_num(); + $flags = intval($flags); + // At the point the username is validated. + $do_validate_user = false; + $do_validate_pass = $flags & $pass_flag; + if ( empty($userdata['yubikey_otp']) ) + { + // no OTP was provided + // make sure the user has allowed logging in with no OTP + if ( !($flags & YK_SEC_ALLOW_NO_OTP) ) + { + // We also might have no Yubikeys enrolled. + $q = $db->sql_query('SELECT 1 FROM ' . table_prefix . "yubikey WHERE user_id = $user_id;"); + if ( !$q ) + $db->die_json(); + + if ( $db->numrows() > 0 ) + { + // Yep at least one key is enrolled. + // I don't think these should be logged because they'll usually just be innocent mistakes. + $db->free_result(); + return array( + 'mode' => 'error', + 'error' => 'yubiauth_err_must_have_otp' + ); + } + // Nope, no keys enrolled, user hasn't enabled Yubikey support + $db->free_result(); + } + // we're ok, use normal password auth + return null; + } + else + { + // user did enter an OTP; make sure it's associated with the username + $yubi_uid = $db->escape(substr($userdata['yubikey_otp'], 0, 12)); + $q = $db->sql_query('SELECT 1 FROM ' . table_prefix . 'yubikey WHERE yubi_uid = \'' . $yubi_uid . '\';'); + if ( !$q ) + $db->die_json(); + if ( $db->numrows() < 1 ) + { + $db->free_result(); + return array( + 'mode' => 'error', + 'error' => 'yubiauth_err_key_not_authorized' + ); + } + $db->free_result(); + $do_validate_otp = true; + } + } + else if ( !empty($userdata['yubikey_otp']) ) + { + // we have an OTP, but no username to work with + $yubi_uid = substr($userdata['yubikey_otp'], 0, 12); + if ( !preg_match('/^[cbdefghijklnrtuv]{12}$/', $yubi_uid ) ) + { + return array( + 'mode' => 'error', + 'error' => 'yubiauth_err_invalid_otp' + ); + } + $q = $db->sql_query('SELECT u.user_id, u.username, u.user_yubikey_flags FROM ' . table_prefix . "users AS u\n" + . " LEFT JOIN " . table_prefix . "yubikey AS y\n" + . " ON ( y.user_id = u.user_id )\n" + . " WHERE y.yubi_uid = '$yubi_uid'\n" + . " GROUP BY u.user_yubikey_flags;"); + if ( !$q ) + $db->_die(); + + if ( $db->numrows() < 1 ) + { + if ( !$do_validate_pass ) + $session->sql('INSERT INTO ' . table_prefix . "logs(log_type,action,time_id,date_string,author,edit_summary,page_text) VALUES\n" + . ' (\'security\', \'' . $auth_log_prefix . 'auth_bad\', '.time().', \'DEPRECATED\', \'(Yubikey)\', ' + . '\''.$db->escape($_SERVER['REMOTE_ADDR']).'\', ' . intval($level) . ')'); + + return array( + 'mode' => 'error', + 'error' => 'yubiauth_err_key_not_authorized' + ); + } + + list($user_id, $username, $flags) = $db->fetchrow_num(); + $do_validate_otp = true; + $do_validate_user = $flags & $user_flag; + $do_validate_pass = $flags & $pass_flag; + // to complete security logs later + $userdata['username'] = $username; + } + else + { + // Nothing - no username or OTP. This request can't be used; throw it out. + return array( + 'mode' => 'error', + 'error' => 'yubiauth_err_nothing_provided' + ); + } + if ( $do_validate_otp ) + { + // We need to validate the OTP. + $otp_check = yubikey_validate_otp($userdata['yubikey_otp']); + if ( !$otp_check['success'] ) + { + if ( !$do_validate_pass ) + $session->sql('INSERT INTO ' . table_prefix . "logs(log_type,action,time_id,date_string,author,edit_summary,page_text) VALUES\n" + . ' (\'security\', \'' . $auth_log_prefix . 'auth_bad\', '.time().', \'DEPRECATED\', \'(Yubikey)\', ' + . '\''.$db->escape($_SERVER['REMOTE_ADDR']).'\', ' . intval($level) . ')'); + + if ( $otp_check['error'] === 'http_failed' ) + { + return array( + 'mode' => 'error', + 'error' => 'yubiauth_err_' . $otp_check['error'], + 'http_error' => $otp_check['http_error'] + ); + } + return array( + 'mode' => 'error', + 'error' => 'yubiauth_err_' . $otp_check['error'] + ); + } + } + if ( $do_validate_user ) + { + if ( empty($username) ) + { + return array( + 'mode' => 'error', + 'error' => 'yubiauth_err_must_have_username' + ); + } + if ( strtolower($username) !== strtolower($userdata['username']) ) + { + // Username incorrect + if ( !$do_validate_pass ) + $session->sql('INSERT INTO ' . table_prefix . "logs(log_type,action,time_id,date_string,author,edit_summary,page_text) VALUES\n" + . ' (\'security\', \'' . $auth_log_prefix . 'auth_bad\', '.time().', \'DEPRECATED\', \'(Yubikey)\', ' + . '\''.$db->escape($_SERVER['REMOTE_ADDR']).'\', ' . intval($level) . ')'); + return array( + 'mode' => 'error', + 'error' => 'invalid_credentials' + ); + } + } + // Do we need to have the password validated? + if ( $do_validate_pass ) + { + if ( empty($userdata['password']) ) + { + return array( + 'mode' => 'error', + 'error' => 'yubiauth_err_must_have_password' + ); + } + // Yes; return and let the login API continue + return null; + } + else + { + // No password required; validated, issue session key + $session->sql('INSERT INTO ' . table_prefix . "logs(log_type,action,time_id,date_string,author,edit_summary,page_text) VALUES\n" + . ' (\'security\', \'' . $auth_log_prefix . 'auth_good\', '.time().', \'DEPRECATED\', \'' . $db->escape($userdata['username']) . '\', ' + . '\''.$db->escape($_SERVER['REMOTE_ADDR']).'\', ' . intval($level) . ')'); + + $q = $db->sql_query('SELECT password FROM ' . table_prefix . "users WHERE user_id = $user_id;"); + if ( !$q ) + $db->_die(); + + list($password) = $db->fetchrow_num(); + $db->free_result(); + + $session->register_session($user_id, $userdata['username'], $password, intval($level), $remember); + return true; + } } function yubikey_add_special_pages() { - global $db, $session, $paths, $template, $plugins; // Common objects - global $lang; - - if ( getConfig('yubikey_enable', '1') != '1' ) - return true; - - $paths->add_page(array( - 'name' => $lang->get('yubiauth_specialpage_yubikey'), - 'urlname' => 'Yubikey', - 'namespace' => 'Special', - 'visible' => 0, 'protected' => 0, 'comments_on' => 0, 'special' => 0 - )); + global $db, $session, $paths, $template, $plugins; // Common objects + global $lang; + + if ( getConfig('yubikey_enable', '1') != '1' ) + return true; + + $paths->add_page(array( + 'name' => $lang->get('yubiauth_specialpage_yubikey'), + 'urlname' => 'Yubikey', + 'namespace' => 'Special', + 'visible' => 0, 'protected' => 0, 'comments_on' => 0, 'special' => 0 + )); } function yubikey_sk_calc($user_id, &$key_pieces, &$sk_mode) { - global $db, $session, $paths, $template, $plugins; // Common objects - // hash the user's yubikeys - $q = $db->sql_query('SELECT yubi_uid FROM ' . table_prefix . "yubikey WHERE user_id = $user_id;"); - if ( !$q ) - $db->_die(); - - while ( $row = $db->fetchrow() ) - { - $key_pieces[] = $row['yubi_uid']; - } + global $db, $session, $paths, $template, $plugins; // Common objects + // hash the user's yubikeys + $q = $db->sql_query('SELECT yubi_uid FROM ' . table_prefix . "yubikey WHERE user_id = $user_id;"); + if ( !$q ) + $db->_die(); + + while ( $row = $db->fetchrow() ) + { + $key_pieces[] = $row['yubi_uid']; + } } function page_Special_Yubikey() { - global $db, $session, $paths, $template, $plugins; // Common objects - - header('Content-type: text/javascript'); - /* - if ( isset($_GET['validate_otp']) ) - { - echo enano_json_encode(yubikey_validate_otp($_GET['validate_otp'])); - return true; - } - */ - if ( isset($_GET['get_flags']) || isset($_POST['get_flags']) ) - { - $yubi_uid = substr($_REQUEST['get_flags'], 0, 12); - if ( !preg_match('/^[cbdefghijklnrtuv]{12}$/', $yubi_uid) ) - { - return print enano_json_encode(array( - 'mode' => 'error', - 'error' => 'invalid_otp' - )); - } - $q = $db->sql_query('SELECT u.user_yubikey_flags FROM ' . table_prefix . "users AS u\n" - . " LEFT JOIN " . table_prefix . "yubikey AS y\n" - . " ON ( y.user_id = u.user_id )\n" - . " WHERE y.yubi_uid = '$yubi_uid'\n" - . " GROUP BY u.user_yubikey_flags;"); - if ( !$q ) - $db->_die(); - - if ( $db->numrows() < 1 ) - { - return print enano_json_encode(array( - 'mode' => 'error', - 'error' => 'key_not_authorized' - )); - } - - list($flags) = $db->fetchrow_num(); - - echo enano_json_encode(array( - // We strip YK_SEC_ALLOW_NO_OTP here for security reasons. - 'flags' => intval($flags & ~YK_SEC_ALLOW_NO_OTP) - )); - - return true; - } + global $db, $session, $paths, $template, $plugins; // Common objects + + header('Content-type: text/javascript'); + /* + if ( isset($_GET['validate_otp']) ) + { + echo enano_json_encode(yubikey_validate_otp($_GET['validate_otp'])); + return true; + } + */ + if ( isset($_GET['get_flags']) || isset($_POST['get_flags']) ) + { + $yubi_uid = substr($_REQUEST['get_flags'], 0, 12); + if ( !preg_match('/^[cbdefghijklnrtuv]{12}$/', $yubi_uid) ) + { + return print enano_json_encode(array( + 'mode' => 'error', + 'error' => 'invalid_otp' + )); + } + $q = $db->sql_query('SELECT u.user_yubikey_flags FROM ' . table_prefix . "users AS u\n" + . " LEFT JOIN " . table_prefix . "yubikey AS y\n" + . " ON ( y.user_id = u.user_id )\n" + . " WHERE y.yubi_uid = '$yubi_uid'\n" + . " GROUP BY u.user_yubikey_flags;"); + if ( !$q ) + $db->_die(); + + if ( $db->numrows() < 1 ) + { + return print enano_json_encode(array( + 'mode' => 'error', + 'error' => 'key_not_authorized' + )); + } + + list($flags) = $db->fetchrow_num(); + + echo enano_json_encode(array( + // We strip YK_SEC_ALLOW_NO_OTP here for security reasons. + 'flags' => intval($flags & ~YK_SEC_ALLOW_NO_OTP) + )); + + return true; + } } diff -r f2aa4bc50d2f -r 5e946a3f405b plugins/yubikey/corelib.php --- a/plugins/yubikey/corelib.php Sat May 29 04:35:49 2010 -0400 +++ b/plugins/yubikey/corelib.php Fri Nov 11 00:30:49 2011 -0500 @@ -10,222 +10,222 @@ function generate_yubikey_field($name = 'yubikey_otp', $value = false) { - global $lang; - - $fid = substr(sha1(microtime() . mt_rand()), 0, 12); - $class = $value ? 'wasfull' : 'wasempty'; - $html = ''; - $html .= ''; - if ( $value ) - { - $html .= '' . $lang->get('yubiauth_ctl_status_enrolled') . ''; - $atext = $lang->get('yubiauth_ctl_btn_change_key'); - $classadd = ' abutton_green'; - } - else - { - $html .= '' . $lang->get('yubiauth_ctl_status_empty') . ''; - $atext = $lang->get('yubiauth_ctl_btn_enroll'); - $classadd = ''; - } - - $html .= ' '; - if ( !empty($value) ) - $html .= htmlspecialchars(substr($value, 0, 12)); - $html .= ' '; - - $html .= ' ' . $atext . ''; - if ( $value ) - { - $html .= ' ' - . $lang->get('yubiauth_ctl_btn_clear') . - ''; - } - - return $html; + global $lang; + + $fid = substr(sha1(microtime() . mt_rand()), 0, 12); + $class = $value ? 'wasfull' : 'wasempty'; + $html = ''; + $html .= ''; + if ( $value ) + { + $html .= '' . $lang->get('yubiauth_ctl_status_enrolled') . ''; + $atext = $lang->get('yubiauth_ctl_btn_change_key'); + $classadd = ' abutton_green'; + } + else + { + $html .= '' . $lang->get('yubiauth_ctl_status_empty') . ''; + $atext = $lang->get('yubiauth_ctl_btn_enroll'); + $classadd = ''; + } + + $html .= ' '; + if ( !empty($value) ) + $html .= htmlspecialchars(substr($value, 0, 12)); + $html .= ' '; + + $html .= ' ' . $atext . ''; + if ( $value ) + { + $html .= ' ' + . $lang->get('yubiauth_ctl_btn_clear') . + ''; + } + + return $html; } function yubikey_validate_otp($otp) { - $api_key = getConfig('yubikey_api_key'); - $api_id = getConfig('yubikey_api_key_id'); - // Don't require an API key or user ID to be installed if we're using local YMS - if ( !(getConfig('yubikey_use_local_yms', 0) && defined('YMS_INSTALLED')) && (!$api_key || !$api_id) ) - { - return array( - 'success' => false, - 'error' => 'missing_api_key' - ); - } - if ( !preg_match('/^[cbdefghijklnrtuv]{44}$/', $otp) ) - { - return array( - 'success' => false, - 'error' => 'otp_invalid_chars' - ); - } - // are we using local YMS? - if ( getConfig('yubikey_use_local_yms', 0) && defined('YMS_INSTALLED') ) - { - $result = yms_validate_otp($otp, $api_id); - if ( $result == 'OK' ) - { - return array( - 'success' => true - ); - } - else - { - return array( - 'success' => false, - 'error' => strtolower("response_{$result}") - ); - } - } - // make HTTP request - require_once( ENANO_ROOT . '/includes/http.php' ); - $auth_url = getConfig('yubikey_auth_server', YK_DEFAULT_VERIFY_URL); - $auth_url = preg_replace('#^https?://#i', '', $auth_url); - if ( !preg_match('#^(\[?[a-z0-9-:]+(?:\.[a-z0-9-:]+\]?)*)(?::([0-9]+))?(/.*)$#U', $auth_url, $match) ) - { - return array( - 'success' => false, - 'error' => 'invalid_auth_url' - ); - } - $auth_server =& $match[1]; - $auth_port = ( !empty($match[2]) ) ? intval($match[2]) : 80; - $auth_uri =& $match[3]; - try - { - $req = new Request_HTTP($auth_server, $auth_uri, 'GET', $auth_port); - $req->add_get('id', strval($api_id)); - $req->add_get('otp', $otp); - $req->add_get('h', yubikey_sign($req->parms_get)); - - $response = $req->get_response_body(); - } - catch ( Exception $e ) - { - return array( - 'success' => false, - 'error' => 'http_failed', - 'http_error' => $e->getMessage() - ); - } - - if ( $req->response_code != HTTP_OK ) - { - return array( - 'success' => false, - 'error' => 'http_response_error' - ); - } - $response = trim($response); - if ( !preg_match_all('/^([a-z0-9_]+)=(.*?)\r?$/m', $response, $matches) ) - { - return array( - 'success' => false, - 'error' => 'malformed_response' - ); - } - $response = array(); - foreach ( $matches[0] as $i => $_ ) - { - $response[$matches[1][$i]] = $matches[2][$i]; - } - // make sure we have a status - if ( !isset($response['status']) ) - { - return array( - 'success' => false, - 'error' => 'response_missing_status' - ); - } - // verify response signature - // MISSING_PARAMETER is the ONLY situation under which an unsigned response is acceptable - if ( $response['status'] !== 'MISSING_PARAMETER' ) - { - if ( !isset($response['h']) ) - { - return array( - 'success' => false, - 'error' => 'response_missing_sig' - ); - } - if ( yubikey_sign($response) !== $response['h'] ) - { - return array( - 'success' => false, - 'error' => 'response_invalid_sig' - ); - } - } - if ( $response['status'] === 'OK' ) - { - if ( yubikey_verify_timestamp($response['t']) ) - { - return array( - 'success' => true - ); - } - else - { - return array( - 'success' => false, - 'error' => 'timestamp_check_failed' - ); - } - } - else - { - return array( - 'success' => false, - 'error' => strtolower("response_{$response['status']}") - ); - } + $api_key = getConfig('yubikey_api_key'); + $api_id = getConfig('yubikey_api_key_id'); + // Don't require an API key or user ID to be installed if we're using local YMS + if ( !(getConfig('yubikey_use_local_yms', 0) && defined('YMS_INSTALLED')) && (!$api_key || !$api_id) ) + { + return array( + 'success' => false, + 'error' => 'missing_api_key' + ); + } + if ( !preg_match('/^[cbdefghijklnrtuv]{44}$/', $otp) ) + { + return array( + 'success' => false, + 'error' => 'otp_invalid_chars' + ); + } + // are we using local YMS? + if ( getConfig('yubikey_use_local_yms', 0) && defined('YMS_INSTALLED') ) + { + $result = yms_validate_otp($otp, $api_id); + if ( $result == 'OK' ) + { + return array( + 'success' => true + ); + } + else + { + return array( + 'success' => false, + 'error' => strtolower("response_{$result}") + ); + } + } + // make HTTP request + require_once( ENANO_ROOT . '/includes/http.php' ); + $auth_url = getConfig('yubikey_auth_server', YK_DEFAULT_VERIFY_URL); + $auth_url = preg_replace('#^https?://#i', '', $auth_url); + if ( !preg_match('#^(\[?[a-z0-9-:]+(?:\.[a-z0-9-:]+\]?)*)(?::([0-9]+))?(/.*)$#U', $auth_url, $match) ) + { + return array( + 'success' => false, + 'error' => 'invalid_auth_url' + ); + } + $auth_server =& $match[1]; + $auth_port = ( !empty($match[2]) ) ? intval($match[2]) : 80; + $auth_uri =& $match[3]; + try + { + $req = new Request_HTTP($auth_server, $auth_uri, 'GET', $auth_port); + $req->add_get('id', strval($api_id)); + $req->add_get('otp', $otp); + $req->add_get('h', yubikey_sign($req->parms_get)); + + $response = $req->get_response_body(); + } + catch ( Exception $e ) + { + return array( + 'success' => false, + 'error' => 'http_failed', + 'http_error' => $e->getMessage() + ); + } + + if ( $req->response_code != HTTP_OK ) + { + return array( + 'success' => false, + 'error' => 'http_response_error' + ); + } + $response = trim($response); + if ( !preg_match_all('/^([a-z0-9_]+)=(.*?)\r?$/m', $response, $matches) ) + { + return array( + 'success' => false, + 'error' => 'malformed_response' + ); + } + $response = array(); + foreach ( $matches[0] as $i => $_ ) + { + $response[$matches[1][$i]] = $matches[2][$i]; + } + // make sure we have a status + if ( !isset($response['status']) ) + { + return array( + 'success' => false, + 'error' => 'response_missing_status' + ); + } + // verify response signature + // MISSING_PARAMETER is the ONLY situation under which an unsigned response is acceptable + if ( $response['status'] !== 'MISSING_PARAMETER' ) + { + if ( !isset($response['h']) ) + { + return array( + 'success' => false, + 'error' => 'response_missing_sig' + ); + } + if ( yubikey_sign($response) !== $response['h'] ) + { + return array( + 'success' => false, + 'error' => 'response_invalid_sig' + ); + } + } + if ( $response['status'] === 'OK' ) + { + if ( yubikey_verify_timestamp($response['t']) ) + { + return array( + 'success' => true + ); + } + else + { + return array( + 'success' => false, + 'error' => 'timestamp_check_failed' + ); + } + } + else + { + return array( + 'success' => false, + 'error' => strtolower("response_{$response['status']}") + ); + } } function yubikey_sign($arr, $use_api_key = false) { - static $api_key = false; - - ksort($arr); - - if ( !$use_api_key ) - { - if ( !$api_key ) - { - $api_key = getConfig('yubikey_api_key'); - $api_key = hexencode(base64_decode($api_key), '', ''); - } - $use_api_key = $api_key; - } - /* - else - { - $use_api_key = hexencode(base64_decode($use_api_key), '', ''); - } - */ - - foreach ( array('h', 'title', 'auth', 'do') as $key ) - { - if ( isset($arr[$key]) ) - unset($arr[$key]); - } - - $req = array(); - foreach ( $arr as $key => $val ) - { - $req[] = "$key=$val"; - } - $req = implode('&', $req); - - $sig = hmac_sha1($req, $use_api_key); - $sig = hexdecode($sig); - $sig = base64_encode($sig); - - return $sig; + static $api_key = false; + + ksort($arr); + + if ( !$use_api_key ) + { + if ( !$api_key ) + { + $api_key = getConfig('yubikey_api_key'); + $api_key = hexencode(base64_decode($api_key), '', ''); + } + $use_api_key = $api_key; + } + /* + else + { + $use_api_key = hexencode(base64_decode($use_api_key), '', ''); + } + */ + + foreach ( array('h', 'title', 'auth', 'do') as $key ) + { + if ( isset($arr[$key]) ) + unset($arr[$key]); + } + + $req = array(); + foreach ( $arr as $key => $val ) + { + $req[] = "$key=$val"; + } + $req = implode('&', $req); + + $sig = hmac_sha1($req, $use_api_key); + $sig = hexdecode($sig); + $sig = base64_encode($sig); + + return $sig; } /** @@ -236,65 +236,65 @@ function yubikey_verify_timestamp($timestamp) { - $tolerance = intval(getConfig('yubikey_api_ts_tolerance', 150)); - - $now = time(); - $timestamp_seconds = yk_strtotime($timestamp); + $tolerance = intval(getConfig('yubikey_api_ts_tolerance', 150)); + + $now = time(); + $timestamp_seconds = yk_strtotime($timestamp); - if ( !$timestamp || !$now || !$timestamp_seconds ) - { - return false; - } + if ( !$timestamp || !$now || !$timestamp_seconds ) + { + return false; + } - if ( ( $timestamp_seconds + $tolerance ) > $now && ( $timestamp_seconds - $tolerance ) < $now ) - { - return true; - } + if ( ( $timestamp_seconds + $tolerance ) > $now && ( $timestamp_seconds - $tolerance ) < $now ) + { + return true; + } - return false; + return false; } function yk_strtotime($timestamp) { - if ( !preg_match('/^([0-9]{4})-([0-9]{2})-([0-9]{2})T([0-9]{2}):([0-9]{2}):([0-9]{2})(?:Z[0-9]+)?$/', $timestamp, $match) ) - return 0; - - $hour = intval($match[4]); - $minute = intval($match[5]); - $second = intval($match[6]); - $month = intval($match[2]); - $day = intval($match[3]); - $year = intval($match[1]); - - return gmmktime($hour, $minute, $second, $month, $day, $year); + if ( !preg_match('/^([0-9]{4})-([0-9]{2})-([0-9]{2})T([0-9]{2}):([0-9]{2}):([0-9]{2})(?:Z[0-9]+)?$/', $timestamp, $match) ) + return 0; + + $hour = intval($match[4]); + $minute = intval($match[5]); + $second = intval($match[6]); + $month = intval($match[2]); + $day = intval($match[3]); + $year = intval($match[1]); + + return gmmktime($hour, $minute, $second, $month, $day, $year); } $plugins->attachHook('compile_template', 'yubikey_attach_headers($this);'); function yubikey_attach_headers(&$template) { - global $db, $session, $paths, $template, $plugins; // Common objects - - if ( getConfig('yubikey_enable', '1') != '1' ) - return true; - - $template->add_header(''); - $template->add_header(''); - // config option for all users have yubikey - $user_flags = 0; - $yk_enabled = 0; - if ( $session->user_logged_in ) - { - $q = $db->sql_query('SELECT COUNT(y.yubi_uid) > 0, u.user_yubikey_flags FROM ' . table_prefix . "yubikey AS y LEFT JOIN " . table_prefix . "users AS u ON ( u.user_id = y.user_id ) WHERE y.user_id = {$session->user_id} GROUP BY u.user_id, u.user_yubikey_flags;"); - if ( !$q ) - $db->_die(); - - list($yk_enabled, $user_flags) = $db->fetchrow_num(); - $db->free_result(); - } - $yk_enabled = intval($yk_enabled); - $user_flags = intval($user_flags); - - $template->add_header(''); + global $db, $session, $paths, $template, $plugins; // Common objects + + if ( getConfig('yubikey_enable', '1') != '1' ) + return true; + + $template->add_header(''); + $template->add_header(''); + // config option for all users have yubikey + $user_flags = 0; + $yk_enabled = 0; + if ( $session->user_logged_in ) + { + $q = $db->sql_query('SELECT COUNT(y.yubi_uid) > 0, u.user_yubikey_flags FROM ' . table_prefix . "yubikey AS y LEFT JOIN " . table_prefix . "users AS u ON ( u.user_id = y.user_id ) WHERE y.user_id = {$session->user_id} GROUP BY u.user_id, u.user_yubikey_flags;"); + if ( !$q ) + $db->_die(); + + list($yk_enabled, $user_flags) = $db->fetchrow_num(); + $db->free_result(); + } + $yk_enabled = intval($yk_enabled); + $user_flags = intval($user_flags); + + $template->add_header(''); } diff -r f2aa4bc50d2f -r 5e946a3f405b plugins/yubikey/usercp.php --- a/plugins/yubikey/usercp.php Sat May 29 04:35:49 2010 -0400 +++ b/plugins/yubikey/usercp.php Fri Nov 11 00:30:49 2011 -0500 @@ -1,7 +1,7 @@ attachHook("userprefs_jbox", "yubikey_ucp_setup();"); $plugins->attachHook("userprefs_body", "return yubikey_user_cp(\$section);"); @@ -12,374 +12,374 @@ function yubikey_ucp_setup() { - userprefs_menu_add('usercp_sec_profile', 'yubiucp_panel_title', makeUrlNS('Special', 'Preferences/Yubikey') . '" onclick="ajaxLoginNavTo(\'Special\', \'Preferences/Yubikey\', '.USER_LEVEL_CHPREF.'); return false;'); + userprefs_menu_add('usercp_sec_profile', 'yubiucp_panel_title', makeUrlNS('Special', 'Preferences/Yubikey') . '" onclick="ajaxLoginNavTo(\'Special\', \'Preferences/Yubikey\', '.USER_LEVEL_CHPREF.'); return false;'); } function yubikey_user_cp($section) { - global $db, $session, $paths, $template, $plugins; // Common objects - global $lang; - - if ( $section !== 'Yubikey' ) - return false; - - if ( $session->auth_level < USER_LEVEL_CHPREF ) - { - redirect(makeUrlNS('Special', 'Login/' . $paths->fullpage, 'level=' . USER_LEVEL_CHPREF, true), 'Authentication required', 'You need to re-authenticate to access this page.', 0); - } - - $count_enabled = intval(getConfig('yubikey_enroll_limit', '3')); - - if ( isset($_POST['submit']) ) - { - csrf_request_confirm(); - - $keys = array(); - if ( isset($_POST['yubikey_enable']) ) - { - for ( $i = 0; $i < $count_enabled; $i++ ) - { - if ( !empty($_POST["yubikey_otp_$i"]) ) - { - $ckey =& $_POST["yubikey_otp_$i"]; - if ( preg_match('/^[cbdefghijklnrtuv]{12,44}$/', $ckey) ) - { - $ckey = substr($ckey, 0, 12); - $keys[] = $ckey; - } - unset($ckey); - } - } - } - // Check for double enrollment - $keys_check = "yubi_uid = '" . implode("' OR yubi_uid = '", $keys) . "'"; - $q = $db->sql_query('SELECT yubi_uid FROM ' . table_prefix . "yubikey WHERE ( $keys_check ) AND user_id != {$session->user_id};"); - if ( !$q ) - $db->_die(); - - if ( $db->numrows() > 0 ) - { - echo '
' . $lang->get('yubiucp_err_double_enrollment') . '
'; - while ( $row = $db->fetchrow() ) - { - foreach ( $keys as $i => $key ) - { - if ( $key == $row['yubi_uid'] ) - { - unset($keys[$i]); - } - } - } - $keys = array_values($keys); - } - $db->free_result(); - - // Remove all currently registered keys - $q = $db->sql_query('DELETE FROM ' . table_prefix . "yubikey WHERE user_id = {$session->user_id};"); - if ( !$q ) - $db->_die(); - - // Enroll any new keys - if ( !empty($keys) ) - { - $query = 'INSERT INTO ' . table_prefix . "yubikey(user_id, yubi_uid) VALUES\n " . - "( $session->user_id, '" . implode("' ),\n ( $session->user_id, '", $keys) . "' );"; - if ( !$db->sql_query($query) ) - $db->_die(); - } - - // Calculate flags - $yubi_flags = 0; - $yubi_flags |= intval($_POST['login_normal_flags']); - $yubi_flags |= intval($_POST['login_elev_flags']); - $yubi_flags |= ( isset($_POST['allow_no_yubikey']) ) ? YK_SEC_ALLOW_NO_OTP : 0; - - // update flags - $q = $db->sql_query('UPDATE ' . table_prefix . "users SET user_yubikey_flags = $yubi_flags WHERE user_id = {$session->user_id};"); - if ( !$q ) - $db->_die(); - - // regenerate session - $q = $db->sql_query('SELECT password FROM ' . table_prefix . "users WHERE user_id = {$session->user_id};"); - if ( !$q ) - $db->_die(); - list($password_hmac) = $db->fetchrow_num(); - - @$session->register_session($session->user_id, $session->username, $password_hmac, USER_LEVEL_MEMBER, false); - $session->logout(USER_LEVEL_CHPREF); - - // redirect back to normal CP - // if OB-ing isn't enabled, require a JS redirect (hey, not many other options...) - if ( @ob_get_contents() ) - { - @ob_end_clean(); - redirect(makeUrlNS('Special', 'Preferences'), $lang->get('yubiucp_msg_save_title'), $lang->get('yubiucp_msg_save_body'), 3); - } - else - { - echo '

' . $lang->get('yubiucp_msg_save_title') . '

'; - echo '

' . $lang->get('yubiucp_msg_save_body') . '

'; - // not much choice here, i'm resorting to javascript because the user CP always - // sends headers :-/ - echo ''; - return true; - } - } - else - { - // Fetch flags - $q = $db->sql_query('SELECT user_yubikey_flags FROM ' . table_prefix . "users WHERE user_id = {$session->user_id};"); - if ( !$q ) - $db->_die(); - - list($yubi_flags) = $db->fetchrow_num(); - $yubi_flags = intval($yubi_flags); - // Fetch user's authorized keys from the DB - $q = $db->sql_query('SELECT yubi_uid FROM ' . table_prefix . "yubikey WHERE user_id = {$session->user_id};"); - if ( !$q ) - $db->_die(); - - $keys = array(); - while ( $row = $db->fetchrow() ) - { - $keys[] = $row['yubi_uid']; - } - $db->free_result(); - } - - while ( count($keys) < $count_enabled ) - { - $keys[] = false; - } - - $enable_checked = ( $keys[0] === false && !isset($_POST['yubikey_enable']) ) ? '' : 'checked="checked"'; - $displaytable = ( $keys[0] === false && !isset($_POST['yubikey_enable']) ) ? 'none' : 'block'; - - $check_normal_keyonly = ( !($yubi_flags & YK_SEC_NORMAL_USERNAME) && !($yubi_flags & YK_SEC_NORMAL_PASSWORD) ) ? 'checked="checked" ' : ''; - $check_normal_username = ( ($yubi_flags & YK_SEC_NORMAL_USERNAME) && !($yubi_flags & YK_SEC_NORMAL_PASSWORD) ) ? 'checked="checked" ' : ''; - $check_normal_userandpw = ( ($yubi_flags & YK_SEC_NORMAL_USERNAME) && ($yubi_flags & YK_SEC_NORMAL_PASSWORD) ) ? 'checked="checked" ' : ''; + global $db, $session, $paths, $template, $plugins; // Common objects + global $lang; + + if ( $section !== 'Yubikey' ) + return false; + + if ( $session->auth_level < USER_LEVEL_CHPREF ) + { + redirect(makeUrlNS('Special', 'Login/' . $paths->fullpage, 'level=' . USER_LEVEL_CHPREF, true), 'Authentication required', 'You need to re-authenticate to access this page.', 0); + } + + $count_enabled = intval(getConfig('yubikey_enroll_limit', '3')); + + if ( isset($_POST['submit']) ) + { + csrf_request_confirm(); + + $keys = array(); + if ( isset($_POST['yubikey_enable']) ) + { + for ( $i = 0; $i < $count_enabled; $i++ ) + { + if ( !empty($_POST["yubikey_otp_$i"]) ) + { + $ckey =& $_POST["yubikey_otp_$i"]; + if ( preg_match('/^[cbdefghijklnrtuv]{12,44}$/', $ckey) ) + { + $ckey = substr($ckey, 0, 12); + $keys[] = $ckey; + } + unset($ckey); + } + } + } + // Check for double enrollment + $keys_check = "yubi_uid = '" . implode("' OR yubi_uid = '", $keys) . "'"; + $q = $db->sql_query('SELECT yubi_uid FROM ' . table_prefix . "yubikey WHERE ( $keys_check ) AND user_id != {$session->user_id};"); + if ( !$q ) + $db->_die(); + + if ( $db->numrows() > 0 ) + { + echo '
' . $lang->get('yubiucp_err_double_enrollment') . '
'; + while ( $row = $db->fetchrow() ) + { + foreach ( $keys as $i => $key ) + { + if ( $key == $row['yubi_uid'] ) + { + unset($keys[$i]); + } + } + } + $keys = array_values($keys); + } + $db->free_result(); + + // Remove all currently registered keys + $q = $db->sql_query('DELETE FROM ' . table_prefix . "yubikey WHERE user_id = {$session->user_id};"); + if ( !$q ) + $db->_die(); + + // Enroll any new keys + if ( !empty($keys) ) + { + $query = 'INSERT INTO ' . table_prefix . "yubikey(user_id, yubi_uid) VALUES\n " . + "( $session->user_id, '" . implode("' ),\n ( $session->user_id, '", $keys) . "' );"; + if ( !$db->sql_query($query) ) + $db->_die(); + } + + // Calculate flags + $yubi_flags = 0; + $yubi_flags |= intval($_POST['login_normal_flags']); + $yubi_flags |= intval($_POST['login_elev_flags']); + $yubi_flags |= ( isset($_POST['allow_no_yubikey']) ) ? YK_SEC_ALLOW_NO_OTP : 0; + + // update flags + $q = $db->sql_query('UPDATE ' . table_prefix . "users SET user_yubikey_flags = $yubi_flags WHERE user_id = {$session->user_id};"); + if ( !$q ) + $db->_die(); + + // regenerate session + $q = $db->sql_query('SELECT password FROM ' . table_prefix . "users WHERE user_id = {$session->user_id};"); + if ( !$q ) + $db->_die(); + list($password_hmac) = $db->fetchrow_num(); + + @$session->register_session($session->user_id, $session->username, $password_hmac, USER_LEVEL_MEMBER, false); + $session->logout(USER_LEVEL_CHPREF); + + // redirect back to normal CP + // if OB-ing isn't enabled, require a JS redirect (hey, not many other options...) + if ( @ob_get_contents() ) + { + @ob_end_clean(); + redirect(makeUrlNS('Special', 'Preferences'), $lang->get('yubiucp_msg_save_title'), $lang->get('yubiucp_msg_save_body'), 3); + } + else + { + echo '

' . $lang->get('yubiucp_msg_save_title') . '

'; + echo '

' . $lang->get('yubiucp_msg_save_body') . '

'; + // not much choice here, i'm resorting to javascript because the user CP always + // sends headers :-/ + echo ''; + return true; + } + } + else + { + // Fetch flags + $q = $db->sql_query('SELECT user_yubikey_flags FROM ' . table_prefix . "users WHERE user_id = {$session->user_id};"); + if ( !$q ) + $db->_die(); + + list($yubi_flags) = $db->fetchrow_num(); + $yubi_flags = intval($yubi_flags); + // Fetch user's authorized keys from the DB + $q = $db->sql_query('SELECT yubi_uid FROM ' . table_prefix . "yubikey WHERE user_id = {$session->user_id};"); + if ( !$q ) + $db->_die(); + + $keys = array(); + while ( $row = $db->fetchrow() ) + { + $keys[] = $row['yubi_uid']; + } + $db->free_result(); + } + + while ( count($keys) < $count_enabled ) + { + $keys[] = false; + } + + $enable_checked = ( $keys[0] === false && !isset($_POST['yubikey_enable']) ) ? '' : 'checked="checked"'; + $displaytable = ( $keys[0] === false && !isset($_POST['yubikey_enable']) ) ? 'none' : 'block'; + + $check_normal_keyonly = ( !($yubi_flags & YK_SEC_NORMAL_USERNAME) && !($yubi_flags & YK_SEC_NORMAL_PASSWORD) ) ? 'checked="checked" ' : ''; + $check_normal_username = ( ($yubi_flags & YK_SEC_NORMAL_USERNAME) && !($yubi_flags & YK_SEC_NORMAL_PASSWORD) ) ? 'checked="checked" ' : ''; + $check_normal_userandpw = ( ($yubi_flags & YK_SEC_NORMAL_USERNAME) && ($yubi_flags & YK_SEC_NORMAL_PASSWORD) ) ? 'checked="checked" ' : ''; - $check_elev_keyonly = ( !($yubi_flags & YK_SEC_ELEV_USERNAME) && !($yubi_flags & YK_SEC_ELEV_PASSWORD) ) ? 'checked="checked" ' : ''; - $check_elev_username = ( ($yubi_flags & YK_SEC_ELEV_USERNAME) && !($yubi_flags & YK_SEC_ELEV_PASSWORD) ) ? 'checked="checked" ' : ''; - $check_elev_userandpw = ( ($yubi_flags & YK_SEC_ELEV_USERNAME) && ($yubi_flags & YK_SEC_ELEV_PASSWORD) ) ? 'checked="checked" ' : ''; - - ?> -

get('yubiucp_panel_title'); ?>

- -
- -
- - - - - -
- get('yubiucp_field_enable_title'); ?>
- get('yubiucp_field_enable_hint'); ?> -
- -
- - - - - - - - - - - - - - - - - -
- get('yubiucp_field_keys_title'); ?>
- get('yubiucp_field_keys_hint'); - if ( $count_enabled > 1 ) - { - echo ' '; - echo $lang->get('yubiucp_field_keys_maximum', array('max' => $count_enabled)); - } - ?> -
- ' . generate_yubikey_field('yubikey_otp_' . $i, $keys[$i]) . '

'; - } - ?> -
- get('yubiucp_field_normal_flags'); ?> - - - -
- - - -
- - -
- get('yubiucp_field_elev_flags'); ?> - - - -
- - - -
- - -
- - -
- - get('yubiucp_field_allow_plain_login_hint'); ?> - -
- - - - -
- -
-
- - - -
- +

get('yubiucp_panel_title'); ?>

+ +
+ +
+ + + + + +
+ get('yubiucp_field_enable_title'); ?>
+ get('yubiucp_field_enable_hint'); ?> +
+ +
+ + + + + + + + + + + + + + + + + +
+ get('yubiucp_field_keys_title'); ?>
+ get('yubiucp_field_keys_hint'); + if ( $count_enabled > 1 ) + { + echo ' '; + echo $lang->get('yubiucp_field_keys_maximum', array('max' => $count_enabled)); + } + ?> +
+ ' . generate_yubikey_field('yubikey_otp_' . $i, $keys[$i]) . '

'; + } + ?> +
+ get('yubiucp_field_normal_flags'); ?> + + + +
+ + + +
+ + +
+ get('yubiucp_field_elev_flags'); ?> + + + +
+ + + +
+ + +
+ + +
+ + get('yubiucp_field_allow_plain_login_hint'); ?> + +
+ + + + +
+ +
+
+ + + +
+ - - - get('yubiauth_lbl_otp_field'); ?> - - - - - - + + + get('yubiauth_lbl_otp_field'); ?> + + + + + + - - - get('yubiucp_reg_field_otp'); ?>
- get('yubiucp_reg_field_otp_hint_required'); - else - echo $lang->get('yubiucp_reg_field_otp_hint_optional'); - ?> - - - - - - - - + + + get('yubiucp_reg_field_otp'); ?>
+ get('yubiucp_reg_field_otp_hint_required'); + else + echo $lang->get('yubiucp_reg_field_otp_hint_optional'); + ?> + + + + + + + + get('yubiucp_reg_err_otp_required'); - return false; - } - if ( $have_otp ) - { - $result = yubikey_validate_otp($_POST['yubikey_otp']); - if ( !$result['success'] ) - { - $error = '' . $lang->get('yubiucp_reg_err_otp_invalid') . '
' . $lang->get("yubiauth_err_{$result['error']}"); - return false; - } - // check for double enrollment - $yubi_uid = substr($_POST['yubikey_otp'], 0, 12); - // Note on SQL injection: yubikey_validate_otp() has already ensured that this is safe - $q = $db->sql_query('SELECT 1 FROM ' . table_prefix . "yubikey WHERE yubi_uid = '$yubi_uid';"); - if ( !$q ) - $db->_die(); - if ( $db->numrows() > 0 ) - { - $error = '' . $lang->get('yubiucp_reg_err_otp_invalid') . '
' . $lang->get('yubiucp_err_double_enrollment_single'); - return false; - } - $db->free_result(); - } + global $db, $session, $paths, $template, $plugins; // Common objects + global $lang; + + $otp_required = getConfig('yubikey_reg_require_otp', '0') == '1'; + $have_otp = !empty($_POST['yubikey_otp']); + if ( $otp_required && !$have_otp ) + { + $error = $lang->get('yubiucp_reg_err_otp_required'); + return false; + } + if ( $have_otp ) + { + $result = yubikey_validate_otp($_POST['yubikey_otp']); + if ( !$result['success'] ) + { + $error = '' . $lang->get('yubiucp_reg_err_otp_invalid') . '
' . $lang->get("yubiauth_err_{$result['error']}"); + return false; + } + // check for double enrollment + $yubi_uid = substr($_POST['yubikey_otp'], 0, 12); + // Note on SQL injection: yubikey_validate_otp() has already ensured that this is safe + $q = $db->sql_query('SELECT 1 FROM ' . table_prefix . "yubikey WHERE yubi_uid = '$yubi_uid';"); + if ( !$q ) + $db->_die(); + if ( $db->numrows() > 0 ) + { + $error = '' . $lang->get('yubiucp_reg_err_otp_invalid') . '
' . $lang->get('yubiucp_err_double_enrollment_single'); + return false; + } + $db->free_result(); + } } function yubikey_register_insert_key($user_id) { - global $db, $session, $paths, $template, $plugins; // Common objects - if ( !empty($_POST['yubikey_otp']) ) - { - $yubi_uid = $db->escape(substr($_POST['yubikey_otp'], 0, 12)); - $q = $db->sql_query('INSERT INTO ' . table_prefix . "yubikey ( user_id, yubi_uid ) VALUES ( $user_id, '$yubi_uid' );"); - if ( !$q ) - $db->_die(); - } + global $db, $session, $paths, $template, $plugins; // Common objects + if ( !empty($_POST['yubikey_otp']) ) + { + $yubi_uid = $db->escape(substr($_POST['yubikey_otp'], 0, 12)); + $q = $db->sql_query('INSERT INTO ' . table_prefix . "yubikey ( user_id, yubi_uid ) VALUES ( $user_id, '$yubi_uid' );"); + if ( !$q ) + $db->_die(); + } }